Messages in this thread Patch in this message | | | From | Brad Larson <> | Date | Sun, 22 Aug 2021 18:22:39 -0700 | Subject | Re: [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control |
| |
Hi Andy,
On Mon, Mar 29, 2021 at 3:41 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Mon, Mar 29, 2021 at 5:01 AM Brad Larson <brad@pensando.io> wrote: > > > > This GPIO driver is for the Pensando Elba SoC which > > provides control of four chip selects on two SPI busses. [...] > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("Pensando Elba SoC SPI chip-select driver"); > > It's funny, you told it can't be a module and you add a dead code. Be > somehow consistent, please.
Yes the code was not consistent with statement that the module cannot being loadable in my reply. I had not used builtin_platform_driver() previously. The updated patchset will be changed to this for the driver.
-module_platform_driver(elba_spics_driver); - -MODULE_LICENSE("GPL v2"); -MODULE_DESCRIPTION("Elba SPI chip-select driver"); +builtin_platform_driver(elba_spics_driver);
where drivers/gpio/Kconfig could be changed to this
--- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -241,10 +241,8 @@ config GPIO_EIC_SPRD Say yes here to support Spreadtrum EIC device.
config GPIO_ELBA_SPICS - bool "Pensando Elba SPI chip-select" + def_bool y depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST - help - Say yes here to support the Pensando Elba SoC SPI chip-select driver
Regards, Brad
| |