lkml.org 
[lkml]   [2021]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH v1 14/37] perf evsel: remove retry_sample_id goto label
    Date
    As far as I can tell, there is no good reason, apart from optimization
    to have the retry_sample_id separate from fallback_missing_features.
    Probably, this label was added to avoid reapplying patches for missing
    features that had already been applied.
    However, missing features that have been added later have not used this
    optimization, always jumping to fallback_missing_features and reapplying
    all missing features.

    This patch removes that label, replacing it with
    fallback_missing_features.

    Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
    ---
    tools/perf/util/evsel.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
    index f61e5dd53f5d2859..7b4bb3229a16524e 100644
    --- a/tools/perf/util/evsel.c
    +++ b/tools/perf/util/evsel.c
    @@ -1825,7 +1825,6 @@ static int evsel__open_cpu(struct evsel *evsel, struct perf_cpu_map *cpus,
    evsel->core.attr.bpf_event = 0;
    if (perf_missing_features.branch_hw_idx)
    evsel->core.attr.branch_sample_type &= ~PERF_SAMPLE_BRANCH_HW_INDEX;
    -retry_sample_id:
    if (perf_missing_features.sample_id_all)
    evsel->core.attr.sample_id_all = 0;

    @@ -2006,7 +2005,7 @@ static int evsel__open_cpu(struct evsel *evsel, struct perf_cpu_map *cpus,
    } else if (!perf_missing_features.sample_id_all) {
    perf_missing_features.sample_id_all = true;
    pr_debug2_peo("switching off sample_id_all\n");
    - goto retry_sample_id;
    + goto fallback_missing_features;
    } else if (!perf_missing_features.lbr_flags &&
    (evsel->core.attr.branch_sample_type &
    (PERF_SAMPLE_BRANCH_NO_CYCLES |
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-08-21 11:21    [W:4.071 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site