lkml.org 
[lkml]   [2021]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] xgene-v2: Fix a resource leak in the error handling path of 'xge_probe()'
    Date
    A successful 'xge_mdio_config()' call should be balanced by a corresponding
    'xge_mdio_remove()' call in the error handling path of the probe, as
    already done in the remove function.

    Update the error handling path accordingly.

    Fixes: ea8ab16ab225 ("drivers: net: xgene-v2: Add MDIO support")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    ---
    drivers/net/ethernet/apm/xgene-v2/main.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c b/drivers/net/ethernet/apm/xgene-v2/main.c
    index 860c18fb7aae..80399c8980bd 100644
    --- a/drivers/net/ethernet/apm/xgene-v2/main.c
    +++ b/drivers/net/ethernet/apm/xgene-v2/main.c
    @@ -677,11 +677,13 @@ static int xge_probe(struct platform_device *pdev)
    ret = register_netdev(ndev);
    if (ret) {
    netdev_err(ndev, "Failed to register netdev\n");
    - goto err;
    + goto err_mdio_remove;
    }

    return 0;

    +err_mdio_remove:
    + xge_mdio_remove(ndev);
    err:
    free_netdev(ndev);

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-08-21 09:36    [W:15.224 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site