[lkml]   [2021]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] i2c: busses: i2c-nomadik: Remove a useless call in the remove function
Since commit a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of
git://"), there is no more
'request_mem_region()' call in this driver.

So remove the 'release_mem_region()' call from the remove function which is
likely a left over.

There is no details in the above commit log, but at its end we can read:

This may explain why this call has been left here.

Fixes: a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://
Signed-off-by: Christophe JAILLET <>
This patch is completely speculative and without details about commit
a410963ba4c0 it's hard to be sure of the intent.

All I can say is that it looks logical to me and that it compiles!
drivers/i2c/busses/i2c-nomadik.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index a2d12a5b1c34..e215a7357873 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -1057,7 +1057,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)

static void nmk_i2c_remove(struct amba_device *adev)
- struct resource *res = &adev->res;
struct nmk_i2c_dev *dev = amba_get_drvdata(adev);

@@ -1067,7 +1066,6 @@ static void nmk_i2c_remove(struct amba_device *adev)
/* disable the controller */
i2c_clr_bit(dev->virtbase + I2C_CR, I2C_CR_PE);
- release_mem_region(res->start, resource_size(res));

static struct i2c_vendor_data vendor_stn8815 = {
 \ /
  Last update: 2021-08-21 09:18    [W:1.056 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site