lkml.org 
[lkml]   [2021]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] staging: r8188eu: core: remove condition with no effect
On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje
<saurav.girepunje@gmail.com> wrote:
>
> Remove the condition with no effect (if == else) in rtw_led.c
> file.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_led.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c
> index 22d4df9c92a5..76cbd5f19f90 100644
> --- a/drivers/staging/r8188eu/core/rtw_led.c
> +++ b/drivers/staging/r8188eu/core/rtw_led.c
> @@ -148,10 +148,7 @@ static void SwLedBlink(struct LED_871x *pLed)
> _set_timer(&(pLed->BlinkTimer), LED_BLINK_SLOWLY_INTERVAL);
> break;
> case LED_BLINK_WPS:
> - if (pLed->BlinkingLedState == RTW_LED_ON)
> - _set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
> - else
> - _set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
> + _set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
> break;
> default:
> _set_timer(&(pLed->BlinkTimer), LED_BLINK_SLOWLY_INTERVAL);
> --
> 2.30.2
>

Thanks for this, looks good.

Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil

\
 
 \ /
  Last update: 2021-08-22 01:58    [W:0.090 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site