lkml.org 
[lkml]   [2021]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V3 12/13] HV/Netvsc: Add Isolation VM support for netvsc driver
    From
    Date
    On 8/20/2021 2:14 AM, Michael Kelley wrote:
    >> @@ -477,6 +521,15 @@ static int netvsc_init_buf(struct hv_device *device,
    >> goto cleanup;
    >> }
    >>
    >> + if (hv_isolation_type_snp()) {
    >> + vaddr = netvsc_remap_buf(net_device->send_buf, buf_size);
    >> + if (!vaddr)
    >> + goto cleanup;
    > I don't think this error case is handled correctly. Doesn't the remapping
    > of the recv buf need to be undone?
    >

    Yes, actually I thought to return error here and free_netvsc_device()
    will help to unmap recv_buffer finally. But I forget to set ret =
    -ENOMEM when add netvsc_remap_buf() helper.

    \
     
     \ /
      Last update: 2021-08-20 20:25    [W:4.063 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site