lkml.org 
[lkml]   [2021]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/7] leds: pca955x: Let the core process the fwnode
Hi!

> - err = devm_led_classdev_register(&client->dev, led);
> + init_data.fwnode = pdata->leds[i].fwnode;
> +
> + if (is_of_node(init_data.fwnode)) {
> + if (to_of_node(init_data.fwnode)->name[0] ==
> + '\0')
> + set_default_label = true;
> + else
> + set_default_label = false;
> + } else {
> + set_default_label = true;
> + }

I'd write it as

set_default_label = true;
if (... && ...)
set_default_label = false;

> + if (set_default_label) {
> + snprintf(default_label, sizeof(default_label),
> + "%d", i);
> + init_data.default_label = default_label;
> + } else {
> + init_data.default_label = NULL;
> + }

init_data.default_label = NULL;
if (...) {
set_default_label) {
> + snprintf(default_label, sizeof(default_label),
> + "%d", i);
> + init_data.default_label = default_label;
}


Thank you,
Pavel
--
http://www.livejournal.com/~pavelmachek
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-08-20 11:03    [W:0.058 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site