Messages in this thread | | | Subject | Re: [PATCH 6/6] staging: r8188eu: remove free_xmit_priv field from struct hal_ops | From | Phillip Potter <> | Date | Fri, 20 Aug 2021 22:56:18 +0100 |
| |
On Thu, 2021-08-19 at 05:14 +0200, Fabio M. De Francesco wrote: > On Thursday, August 19, 2021 1:42:53 AM CEST Phillip Potter wrote: > > Remove free_xmit_priv function pointer field from struct hal_ops > > definition > > in include/hal_intf.h, as it is now no longer used anywhere in the > > driver. > > > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > > --- > > drivers/staging/r8188eu/include/hal_intf.h | 1 - > > 1 file changed, 1 deletion(-) > > This entry could have been removed in patch 4/6 or 5/6, but I guess > it's okay to do that here as well. Perhaps the three patches from 4/6 > to 6/6 could have been merged into one (because since 4/6 was > immediately clear that this operation has no use at all). > > Aside from the above considerations, it looks good. So... > > Acked by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > > Thanks, > > Fabio > > > >
Dear Fabio,
Thank you for your feedback and acknowledgements for this series, much appreciated.
Regards, Phil
| |