lkml.org 
[lkml]   [2021]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 04/40] btrfs: mark compressed range uptodate only if all bio succeed
    Date
    From: Goldwyn Rodrigues <rgoldwyn@suse.de>

    commit 240246f6b913b0c23733cfd2def1d283f8cc9bbe upstream.

    In compression write endio sequence, the range which the compressed_bio
    writes is marked as uptodate if the last bio of the compressed (sub)bios
    is completed successfully. There could be previous bio which may
    have failed which is recorded in cb->errors.

    Set the writeback range as uptodate only if cb->errors is zero, as opposed
    to checking only the last bio's status.

    Backporting notes: in all versions up to 4.4 the last argument is always
    replaced by "!cb->errors".

    CC: stable@vger.kernel.org # 4.4+
    Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/btrfs/compression.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/btrfs/compression.c
    +++ b/fs/btrfs/compression.c
    @@ -273,7 +273,7 @@ static void end_compressed_bio_write(str
    cb->compressed_pages[0]->mapping = cb->inode->i_mapping;
    btrfs_writepage_endio_finish_ordered(cb->compressed_pages[0],
    cb->start, cb->start + cb->len - 1,
    - bio->bi_status == BLK_STS_OK);
    + !cb->errors);
    cb->compressed_pages[0]->mapping = NULL;

    end_compressed_writeback(inode, cb);

    \
     
     \ /
      Last update: 2021-08-02 16:12    [W:4.225 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site