lkml.org 
[lkml]   [2021]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 1/6] mfd: sy7636a: Initial commit
On Mon, 02 Aug 2021, Alistair Francis wrote:

> On Wed, Jul 21, 2021 at 12:53 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Thu, 08 Jul 2021, Alistair Francis wrote:
> >
> > > Initial support for the Silergy SY7636A Power Management chip.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > ---
> > > drivers/mfd/Kconfig | 9 +++++
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/sy7636a.c | 81 +++++++++++++++++++++++++++++++++++++
> > > include/linux/mfd/sy7636a.h | 47 +++++++++++++++++++++
> > > 4 files changed, 138 insertions(+)
> > > create mode 100644 drivers/mfd/sy7636a.c
> > > create mode 100644 include/linux/mfd/sy7636a.h

[...]

> > > +struct sy7636a {
> > > + struct device *dev;
> > > + struct regmap *regmap;
> > > + struct gpio_desc *pgood_gpio;
> >
> > This looks unused?
>
> It is used in the syy636a-regulator

If it's only used in one driver, please declare it there.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2021-08-02 12:24    [W:0.099 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site