lkml.org 
[lkml]   [2021]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next] net: fec: fix MAC internal delay doesn't work
Date

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: 2021年8月3日 4:33
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: davem@davemloft.net; andrew@lunn.ch; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work
>
> On Fri, 30 Jul 2021 19:47:09 +0800 Joakim Zhang wrote:
> > @@ -3806,6 +3827,10 @@ fec_probe(struct platform_device *pdev)
> > fep->phy_interface = interface;
> > }
> >
> > + ret = fec_enet_parse_rgmii_delay(fep, np);
> > + if (ret)
> > + goto failed_phy;
>
> You're jumping to the wrong label, it looks like phy_node needs to be released
> at this point.

Yes, I will correct it. Thanks Jakub.

Best Regards,
Joakim Zhang
\
 
 \ /
  Last update: 2021-08-03 04:01    [W:0.048 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site