Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 19 Aug 2021 20:24:11 +0300 | Subject | Re: [PATCH] media: atomisp: restore missing 'return' statement |
| |
On Fri, Aug 13, 2021 at 7:39 PM Kees Cook <keescook@chromium.org> wrote: > > On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > The input_system_configure_channel_sensor() function lost its final > > return code in a previous patch: > > > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor': > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type] > > > > Restore what was there originally. > > > > Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > I hit this too. Thanks! > > Reviewed-by: Kees Cook <keescook@chromium.org>
Me too, Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Pavel, how have you tested it?
-- With Best Regards, Andy Shevchenko
| |