lkml.org 
[lkml]   [2021]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 10/61] kernel/fork: Use maple tree for dup_mmap() during forking
Date
* Hillf Danton <hdanton@sina.com> [210818 04:36]:
> On Tue, 17 Aug 2021 15:47:11 +0000 Liam R. Howlett wrote:
> >
> > static inline void mmget(struct mm_struct *mm)
> > {
> > + mt_set_in_rcu(&mm->mm_mt);
> > atomic_inc(&mm->mm_users);
> > }
> >
> > static inline bool mmget_not_zero(struct mm_struct *mm)
> > {
> > + /*
> > + * There is a race below during task tear down that can cause the maple
> > + * tree to enter rcu mode with only a single user. If this race
> > + * happens, the result would be that the maple tree nodes would remain
> > + * active for an extra RCU read cycle.
> > + */
> > + mt_set_in_rcu(&mm->mm_mt);
> > return atomic_inc_not_zero(&mm->mm_users);
> > }
>
> Nit, leave the mm with zero refcount intact.
>
> if (atomic_inc_not_zero(&mm->mm_users)) {
> mt_set_in_rcu(&mm->mm_mt);
> return true;
> }
> return false;

Thanks for looking at this.

I thought about that, but came up with the following scenario:

thread 1 thread 2
mmget(mm)
mmget_not_zero() enter..
atomic_inc_not_zero(&mm->mm_users)
mmput(mm)
mt_set_in_rcu(&mm->mm_mt);
return true;


So I think the above does not remove the race, but does add instructions
to each call to mmget_not_zero(). I thought the race of having nodes
sitting around for an rcu read cycle was worth the trade off.

Cheers,
Liam
\
 
 \ /
  Last update: 2021-08-18 16:56    [W:0.311 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site