lkml.org 
[lkml]   [2021]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 08/16] iio: adc: max1027: Explain better how the trigger state gets changed
Date
It may appear strange to configure the trigger to start upon register
write while we want to disable the trigger. Explain why we do this in
the comment.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/iio/adc/max1027.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c
index 59914fcfd320..4a78c9cbc339 100644
--- a/drivers/iio/adc/max1027.c
+++ b/drivers/iio/adc/max1027.c
@@ -401,7 +401,12 @@ static int max1027_set_cnvst_trigger_state(struct iio_trigger *trig, bool state)
if (ret < 0)
return ret;
} else {
- /* Start acquisition on conversion register write */
+ /*
+ * Start acquisition on conversion register write, which
+ * basically disables triggering conversions upon cnvst changes
+ * and thus has the effect of disabling the external hardware
+ * trigger.
+ */
ret = max1027_configure_trigger(indio_dev);
if (ret)
return ret;
--
2.27.0
\
 
 \ /
  Last update: 2021-08-18 13:13    [W:0.337 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site