lkml.org 
[lkml]   [2021]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 41/63] net: 802: Use memset_startat() to clear struct fields
    Date
    In preparation for FORTIFY_SOURCE performing compile-time and run-time
    field bounds checking for memset(), avoid intentionally writing across
    neighboring fields.

    Use memset_startat() so memset() doesn't get confused about writing
    beyond the destination member that is intended to be the starting point
    of zeroing through the end of the struct.

    Cc: Jes Sorensen <jes@trained-monkey.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: linux-hippi@sunsite.dk
    Cc: netdev@vger.kernel.org
    Signed-off-by: Kees Cook <keescook@chromium.org>
    ---
    net/802/hippi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/802/hippi.c b/net/802/hippi.c
    index f80b33a8f7e0..6f71ffc8bdd1 100644
    --- a/net/802/hippi.c
    +++ b/net/802/hippi.c
    @@ -65,7 +65,7 @@ static int hippi_header(struct sk_buff *skb, struct net_device *dev,
    hip->le.src_addr_type = 2; /* 12 bit SC address */

    memcpy(hip->le.src_switch_addr, dev->dev_addr + 3, 3);
    - memset(&hip->le.reserved, 0, 16);
    + memset_startat(&hip->le, 0, reserved);

    hip->snap.dsap = HIPPI_EXTENDED_SAP;
    hip->snap.ssap = HIPPI_EXTENDED_SAP;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-08-18 08:20    [W:3.039 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site