Messages in this thread | | | Subject | Re: [PATCH v5 08/11] powerpc/pseries/iommu: Update remove_dma_window() to accept property name | From | Leonardo Brás <> | Date | Tue, 17 Aug 2021 02:59:46 -0300 |
| |
Hello Fred, thanks for the feedback!
On Tue, 2021-07-20 at 19:51 +0200, Frederic Barrat wrote: > > > On 16/07/2021 10:27, Leonardo Bras wrote: > > Update remove_dma_window() so it can be used to remove DDW with a > > given > > property name. > > > > This enables the creation of new property names for DDW, so we can > > have different usage for it, like indirect mapping. > > > > Signed-off-by: Leonardo Bras <leobras.c@gmail.com> > > Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru> > > --- > > arch/powerpc/platforms/pseries/iommu.c | 21 +++++++++++---------- > > 1 file changed, 11 insertions(+), 10 deletions(-) > > > > diff --git a/arch/powerpc/platforms/pseries/iommu.c > > b/arch/powerpc/platforms/pseries/iommu.c > > index 108c3dcca686..17c6f4706e76 100644 > > --- a/arch/powerpc/platforms/pseries/iommu.c > > +++ b/arch/powerpc/platforms/pseries/iommu.c > > @@ -830,31 +830,32 @@ static void remove_dma_window(struct > > device_node *np, u32 *ddw_avail, > > np, ret, ddw_avail[DDW_REMOVE_PE_DMA_WIN], > > liobn); > > } > > > > -static void remove_ddw(struct device_node *np, bool remove_prop) > > +static int remove_ddw(struct device_node *np, bool remove_prop, > > const char *win_name) > > { > > > Why switch to returning an int? None of the callers check it.
IIRC, in a previous version it did make sense, which is not the case anymore. I will revert this.
Thanks!
> > Fred
| |