lkml.org 
[lkml]   [2021]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 10/11] powerpc/pseries/iommu: Make use of DDW for indirect mapping
From
Date
Hello Alexey, Fred. Thanks for reviewing!


On Wed, 2021-07-21 at 13:32 +1000, Alexey Kardashevskiy wrote:
> > >     spin_lock(&direct_window_list_lock);
> >
> >
> >
> >
> > Somewhere around here, we have:
> >
> > out_remove_win:
> >      remove_ddw(pdn, true, DIRECT64_PROPNAME);
> >
> > We should replace with:
> >      remove_ddw(pdn, true, win_name);
>
>
> True. Good spotting. Or rework remove_dma_window() to take just a
> liobn.
> Thanks,

Fred,
Good catch! On rebasing the last changes I did miss this one.

Due to reworking v5 06/11, I ended up with a solution that takes a
liobn instead of a win name (as suggested by Alexey), and this one is
no more :)


>
> >
> >
> >    Fred
> >
> >
> >
> > >
>

Thanks!

\
 
 \ /
  Last update: 2021-08-17 07:59    [W:0.073 / U:2.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site