Messages in this thread | | | From | Krzysztof Hałasa <> | Subject | Re: [PATCH v2] PCIe: limit Max Read Request Size on i.MX to 512 bytes | Date | Tue, 17 Aug 2021 06:29:26 +0200 |
| |
Rob Herring <robh@kernel.org> writes:
>> +#ifdef CONFIG_ARM >> + if (rq > max_pcie_mrrs) >> + rq = max_pcie_mrrs; >> +#endif > > My objection wasn't having another kconfig option so much as I don't > think we need one at all here unless Bjorn feels otherwise. It's 2 > bytes of data and about 3 instructions (load, cmp, store). > > If we do have a config option, using or basing on the arch is wrong. > Has nothing to do with the arch. Are the other platforms needing this > arm32 as well?
Yes,
I can buy the "universal ARM32 kernel" argument, but otherwise it's just nonfunctional bloat. A small one, yes. -- Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz Przemysłowy Instytut Automatyki i Pomiarów PIAP Al. Jerozolimskie 202, 02-486 Warszawa
| |