Messages in this thread | | | Date | Mon, 16 Aug 2021 11:54:35 +0200 | From | Marek Behún <> | Subject | Re: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event |
| |
On Mon, 16 Aug 2021 08:56:36 +0000 "Song, Yoong Siang" <yoong.siang.song@intel.com> wrote:
> Yes, you are right. I missed the effect of get_wol. > Is it needed in future to implement link change interrupt in phy > driver? Cause I dint see much phy driver implement link change > interrupt.
If there is a board that has interrupt pin wired correctly from the PHY and the interrupt controller is safe to use (i.e. it is not a PCA953x which cannot handle interrupt storms correctly), then I think the PHY driver should use the interrupt, instead of polling.
Marek
| |