lkml.org 
[lkml]   [2021]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v6 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder
Date
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Saturday, July 31, 2021 1:42 AM
> To: Kammela, Gayatri <gayatri.kammela@intel.com>
> Cc: Platform Driver <platform-driver-x86@vger.kernel.org>; Mark Gross
> <mgross@linux.intel.com>; Hans de Goede <hdegoede@redhat.com>;
> Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; You-Sheng Yang
> <vicamo.yang@canonical.com>; Pandruvada, Srinivas
> <srinivas.pandruvada@intel.com>; Box, David E <david.e.box@intel.com>;
> Qin, Chao <chao.qin@intel.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Mashiah, Tamar <tamar.mashiah@intel.com>;
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rajat Jain
> <rajatja@google.com>; Shyam Sundar S K <Shyam-sundar.S-k@amd.com>;
> Alex Deucher <Alexander.Deucher@amd.com>; mlimonci@amd.com
> Subject: Re: [PATCH v6 1/5] platform/x86/intel: intel_pmc_core: Move
> intel_pmc_core* files to pmc subfolder
>
> On Sat, Jul 31, 2021 at 9:10 AM Gayatri Kammela
> <gayatri.kammela@intel.com> wrote:
> >
> > As part of collecting Intel x86 specific drivers in their own folder,
> > move intel_pmc_core* files to its own subfolder there.
>
> ...
>
> > .../pmc/pltdrv.c} | 0
>
> I would go further and spell it as platform.c.
Hi Andy, sure! I have renamed the file as core_platform.c in the next version , so that it is consistent with the rest of the file names under intel/pmc/ (core.c, core.h , core_platform.c)
>
> ...
>
> > -F: drivers/platform/x86/intel_pmc_core*
> > +F: drivers/platform/x86/intel/pmc/core*
>
> This seems incorrect.
Yeah I agree. With the above change in the filename (core_platform.c), I think, this line in MAINTAINERS would make sense.
>
> ...
>
> > + Supported features:
> > + - SLP_S0_RESIDENCY counter
> > + - PCH IP Power Gating status
> > + - LTR Ignore / LTR Show
>
> > + - MPHY/PLL gating status (Sunrisepoint PCH only)
> > + - SLPS0 Debug registers (Cannonlake/Icelake PCH)
> > + - Low Power Mode registers (Tigerlake and beyond)
>
> Perhaps you may use the opportunity to spell codenames in a better way, i.e.
> Sunrise Point
> Cannon Lake
> Ice Lake
> Tiger Lake
>
> as it's done almost everywhere else in the kernel.
Sure! I have made changes as per your suggestion. Thanks!
>
> ...
>
> > +obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o
> > +intel_pmc_core-objs += core.o
>
> objs suffix is not for kernel modules.
> Moreover, := has a difference to +=. Why is the latter in use?
Yeah, it is not needed for kernel modules. I have made changes accordingly.
>
> > +obj-$(CONFIG_INTEL_PMC_CORE) += pltdrv.o
>
> This will have the very same issue as with the core module. On top of that,
> do you need a separate module for it? If so, why?
I made changes, so that we won't have the same issue as with the core module. core_pltdrv has always been made as a separate module, Andy. Do you suggest that we don't need it as a separate module?
>
> --
> With Best Regards,
> Andy Shevchenko
\
 
 \ /
  Last update: 2021-08-16 19:00    [W:0.051 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site