lkml.org 
[lkml]   [2021]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/2] dt-bindings: PCI: Add Apple PCI controller
Hi Marc,

> > Document the properties used by the Apple PCI controller. This is a
> > fairly standard PCI controller, although it is not derived from any
> > known non-Apple IP.
> >
> > Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
>
> I would rather you post something as an extension to Mark's work, for
> multiple reasons:
>
> - Mark's patch is still being discussed, and is the current
> reference (specially given that it is already in use in OpenBSD and
> u-boot).
>
> - we cannot have multiple bindings. There can only be one, shared
> across implementations. Otherwise, you need a different kernel
> depending on whether you are booting from m1n1 or u-boot.
>
> - what you have here is vastly inconsistent (you are describing the
> MSIs twice, using two different methods).

Absolutely agree, the frankenstein bindings here were the main reason v1
was marked RFC. For v2, I've rebased on Mark's patch, which makes a
bunch of driver magic disappear.

Alyssa

\
 
 \ /
  Last update: 2021-08-16 05:18    [W:0.100 / U:3.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site