lkml.org 
[lkml]   [2021]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/1] asus-wmi: add platform_profile support


On Sat, Aug 14 2021 at 16:31:02 +1200, Luke D. Jones <luke@ljones.dev>
wrote:
> Changelog:
> - V2
> + Correctly unregister from platform_profile if
> throttle_thermal_policy fails
> + Do platform_profile_notify() in both
> throttle_thermal_policy_store()
> and in throttle_thermal_policy_switch_next()
> + Remove unnecessary prep for possible fan-boost modes as this
> doesn't match expected platform_profile behaviour
> - V3
> + Add missing declaration for err in
> throttle_thermal_policy_switch_next
>
> Luke D. Jones (1):
> asus-wmi: Add support for platform_profile
>
> drivers/platform/x86/asus-wmi.c | 139
> +++++++++++++++++++++++++++++++-
> 1 file changed, 135 insertions(+), 4 deletions(-)
>
> --
> 2.31.1

Hi,

I teested the patch again and it appears that the
platform_profile_notify() in both throttle_thermal_policy_store() and
throttle_thermal_policy_switch_next() updates the
/sys/firmware/acpi/platform_profile sysfs path fine, but userspace
isn't updated?

The way I'm checking is:
1. echo 1 |sudo tee
/sys/devices/platform/asus-nb-wmi/throttle_thermal_policy
2. cat -p /sys/firmware/acpi/platform_profile
- performance (updated correctly by platform_profile_notify)
3. Check gnome-settings, not updated.

Doing `echo "performance" |sudo tee
/sys/firmware/acpi/platform_profile` updates both
throttle_thermal_policy and userspace as expected. I'm wondering if
I've missed something?

Cheers,
Luke.


\
 
 \ /
  Last update: 2021-08-14 09:52    [W:0.126 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site