lkml.org 
[lkml]   [2021]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: r8188eu: os_dep: Remove defined but not used variables
From
Date
On 8/14/21 6:08 PM, Fabio M. De Francesco wrote:
> Remove defined but not used const variables. Issues detected by GCC
> running with -Wunused-const-variable option enabled.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 21 --------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index 38ee41f9d2ba..d9fdd83218dc 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -84,11 +84,6 @@ static u32 rtw_rates[] = {1000000, 2000000, 5500000, 11000000,
> 6000000, 9000000, 12000000, 18000000, 24000000, 36000000,
> 48000000, 54000000};
>
> -static const char * const iw_operation_mode[] = {
> - "Auto", "Ad-Hoc", "Managed", "Master", "Repeater",
> - "Secondary", "Monitor"
> -};
> -
> void indicate_wx_scan_complete_event(struct adapter *padapter)
> {
> union iwreq_data wrqu;
> @@ -6666,19 +6661,3 @@ struct iw_handler_def rtw_handlers_def = {
> .num_private_args = sizeof(rtw_private_args) / sizeof(struct iw_priv_args),
> .get_wireless_stats = rtw_get_wireless_stats,
> };
> -
> -/* copy from net/wireless/wext.c start */
> -/* ---------------------------------------------------------------- */
> -/*
> - * Calculate size of private arguments
> - */
> -static const char iw_priv_type_size[] = {
> - 0, /* IW_PRIV_TYPE_NONE */
> - 1, /* IW_PRIV_TYPE_BYTE */
> - 1, /* IW_PRIV_TYPE_CHAR */
> - 0, /* Not defined */
> - sizeof(__u32), /* IW_PRIV_TYPE_INT */
> - sizeof(struct iw_freq), /* IW_PRIV_TYPE_FLOAT */
> - sizeof(struct sockaddr), /* IW_PRIV_TYPE_ADDR */
> - 0, /* Not defined */
> -};
>

Looks good to me, thanks.

Acked-by: Michael Straube <straube.linux@gmail.com>

Michael

\
 
 \ /
  Last update: 2021-08-14 19:03    [W:0.036 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site