Messages in this thread | | | Subject | Re: [PATCH v2] genirq/timings: Fix error return code in irq_timings_test_irqs() | From | Daniel Lezcano <> | Date | Fri, 13 Aug 2021 20:32:39 +0200 |
| |
On 11/08/2021 11:33, Zhen Lei wrote: > Fix to return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> --- > kernel/irq/timings.c | 2 ++ > 1 file changed, 2 insertions(+) > > v1 --> v2: > Replace -EFAULT with two more appropriate error codes. > > diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c > index d309d6fbf5bd..59affb3bfdfa 100644 > --- a/kernel/irq/timings.c > +++ b/kernel/irq/timings.c > @@ -794,12 +794,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti) > > __irq_timings_store(irq, irqs, ti->intervals[i]); > if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) { > + ret = -EBADSLT; > pr_err("Failed to store in the circular buffer\n"); > goto out; > } > } > > if (irqs->count != ti->count) { > + ret = -ERANGE; > pr_err("Count differs\n"); > goto out; > } >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |