lkml.org 
[lkml]   [2021]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe:Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb status to use string
From
Date
发件人:Chao Yu <chao@kernel.org>
发送日期:2021-08-13 22:41:02
收件人:"李扬韬" <frank.li@vivo.com>
抄送人:jaegeuk@kernel.org,linux-f2fs-devel@lists.sourceforge.net,linux-kernel@vger.kernel.org
主题:Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string>On 2021/8/13 22:17, 李扬韬 wrote:
>> HI Chao,
>>
>> From: Chao Yu <chao@kernel.org>
>> Date: 2021-08-13 22:09:53
>> To: Yangtao Li <frank.li@vivo.com>,jaegeuk@kernel.org
>> Cc: linux-f2fs-devel@lists.sourceforge.net,linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string>On 2021/8/13 22:01, Yangtao Li wrote:
>>>> Do not use numbers but strings to improve readability when flag is set.
>>>
>>> This breaks output rule of sysfs entry, see below link:
>>>
>> Which rule? one entry should show one value?
>
>Yes, one value per file please, which is suggested by Greg.
>
>https://lkml.org/lkml/2021/6/3/319
>
>>
>> But I see that:
>> # cat /sys/fs/f2fs/<disk>/features
>> encryption, quota_ino, verity, pin_file
>>
>> So the format of features also wrong?
>
> What: /sys/fs/f2fs/<disk>/features
> Date: July 2017
> Contact: "Jaegeuk Kim" <jaegeuk@kernel.org>
> Description: <deprecated: should use /sys/fs/f2fs/<disk>/feature_list/

OK, So Maybe we can make something like following?

/sys/fs/f2fs/<disk>/sbi_status/fsck

Yangtao

\
 
 \ /
  Last update: 2021-08-13 16:56    [W:0.060 / U:3.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site