Messages in this thread | | | Date | Fri, 13 Aug 2021 22:34:17 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v1 net-next 4/7] ptp_pch: Switch to use module_pci_driver() macro |
| |
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ptp_pch-use-mac_pton/20210813-203135 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b769cf44ed55f4b277b89cf53df6092f0c9082d0 config: nios2-randconfig-r023-20210813 (attached as .config) compiler: nios2-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6c1fff5c80fe8f1a12c20bac2d28ebfa5960bde7 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/ptp_pch-use-mac_pton/20210813-203135 git checkout 6c1fff5c80fe8f1a12c20bac2d28ebfa5960bde7 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/ptp/ptp_pch.c:604:1: warning: data definition has no type or storage class 604 | module_pci_driver(pch_driver); | ^~~~~~~~~~~~~~~~~ >> drivers/ptp/ptp_pch.c:604:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] >> drivers/ptp/ptp_pch.c:604:1: warning: parameter names (without types) in function declaration drivers/ptp/ptp_pch.c:597:26: warning: 'pch_driver' defined but not used [-Wunused-variable] 597 | static struct pci_driver pch_driver = { | ^~~~~~~~~~ cc1: some warnings being treated as errors
vim +604 drivers/ptp/ptp_pch.c
596 597 static struct pci_driver pch_driver = { 598 .name = KBUILD_MODNAME, 599 .id_table = pch_ieee1588_pcidev_id, 600 .probe = pch_probe, 601 .remove = pch_remove, 602 .driver.pm = &pch_pm_ops, 603 }; > 604 module_pci_driver(pch_driver); 605
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |