lkml.org 
[lkml]   [2021]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] perf test: Do not compare overheads in the zstd comp test
On Thu, Aug 12, 2021 at 4:57 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> The overhead can vary on each run so it'd make the test failed
> sometimes. Also order of hist entry can change.
>
> Use perf report -F option to omit the overhead field and sort the
> result alphabetically.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> index 045723b3d992..8a168cf8bacc 100755
> --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> @@ -25,8 +25,8 @@ check_compressed_stats() {
>
> check_compressed_output() {
> $perf_tool inject -i $trace_file -o $trace_file.decomp &&
> - $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output &&
> - $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output &&
> + $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output &&
> + $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output &&
> diff $trace_file.comp.output $trace_file.decomp.output
> }
>
> --
> 2.33.0.rc1.237.g0d66db33f3-goog
>

\
 
 \ /
  Last update: 2021-08-13 02:10    [W:0.048 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site