Messages in this thread Patch in this message | | | From | "S, Shirish" <> | Subject | RE: [PATCH] sched/debug: print column titles of show_state_filter()[V2] | Date | Thu, 12 Aug 2021 11:07:25 +0000 |
| |
[AMD Official Use Only]
Done.
Thanks.
Regards, Shirish S
-----Original Message----- From: Steven Rostedt <rostedt@goodmis.org> Sent: Wednesday, August 11, 2021 7:07 PM To: S, Shirish <Shirish.S@amd.com> Cc: Ingo Molnar <mingo@redhat.com>; Peter Zijlstra <peterz@infradead.org>; Juri Lelli <juri.lelli@redhat.com>; Vincent Guittot <vincent.guittot@linaro.org>; Dietmar Eggemann <dietmar.eggemann@arm.com>; Ben Segall <bsegall@google.com>; Mel Gorman <mgorman@suse.de>; Daniel Bristot de Oliveira <bristot@redhat.com>; linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/debug: print column titles of show_state_filter()[V2]
On Wed, 14 Jul 2021 08:57:05 +0530 Shirish S <shirish.s@amd.com> wrote:
> This addition in the debug output shall improve readablitly.. > Its not intuitive for users that the pid printed in last column is of > parent process.
Hi Shirish,
perhaps add a before and after output to show people what you are trying to improve, and that can help the maintainers see if it is a useful patch or not.
Note, I'm only a reviewer of scheduling code, I'm not one that can pull in the patch.
-- Steve
> > v2: Dropped #ifdef logic > > Signed-off-by: Shirish S <shirish.s@amd.com> > Suggested-by: Steven Rostedt <rostedt@goodmis.org> > --- > kernel/sched/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c index > 2d9ff40f4661..22cee4c0f4b1 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -8194,6 +8194,9 @@ void show_state_filter(unsigned int > state_filter) { > struct task_struct *g, *p; > > + pr_info(" task%*s", BITS_PER_LONG == 32 ? 38 : 46, > + "PC stack pid father\n"); > + > rcu_read_lock(); > for_each_process_thread(g, p) { > /*
| |