Messages in this thread | | | From | Phillip Potter <> | Date | Thu, 12 Aug 2021 22:09:15 +0100 | Subject | Re: [PATCH 2/3] staging: r8188eu: Remove uninitialized use of ether_type in portctrl() |
| |
On Thu, 12 Aug 2021 at 21:40, Nathan Chancellor <nathan@kernel.org> wrote: > > After commit 987219ad34a6 ("staging: r8188eu: remove lines from Makefile > that silence build warnings"), clang warns: > > drivers/staging/r8188eu/core/rtw_recv.c:499:8: warning: variable > 'ether_type' is uninitialized when used here [-Wuninitialized] > if (ether_type == eapol_type) > ^~~~~~~~~~ > drivers/staging/r8188eu/core/rtw_recv.c:458:16: note: initialize the > variable 'ether_type' to silence this warning > u16 ether_type; > ^ > = 0 > 1 warning generated. > > This if statement sets the exact same assignment as above so just remove > it. > > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/staging/r8188eu/core/rtw_recv.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c > index 9b3637e49052..8df38db9572c 100644 > --- a/drivers/staging/r8188eu/core/rtw_recv.c > +++ b/drivers/staging/r8188eu/core/rtw_recv.c > @@ -495,10 +495,6 @@ static struct recv_frame *portctrl(struct adapter *adapter, struct recv_frame *p > /* allowed */ > /* check decryption status, and decrypt the frame if needed */ > prtnframe = precv_frame; > - /* check is the EAPOL frame or not (Rekey) */ > - if (ether_type == eapol_type) > - /* check Rekey */ > - prtnframe = precv_frame; > } > } else { > prtnframe = precv_frame; > -- > 2.33.0.rc2 >
Thanks again.
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Regards, Phil
| |