lkml.org 
[lkml]   [2021]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v5 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer
Date
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Wednesday, August 4, 2021 1:08 PM
> To: Sanil, Shruthi <shruthi.sanil@intel.com>
> Cc: Rob Herring <robh@kernel.org>; daniel.lezcano@linaro.org;
> tglx@linutronix.de; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; andriy.shevchenko@linux.intel.com;
> kris.pan@linux.intel.com; mgross@linux.intel.com; Thokala, Srikanth
> <srikanth.thokala@intel.com>; Raja Subramanian, Lakshmi Bai
> <lakshmi.bai.raja.subramanian@intel.com>; Sangannavar, Mallikarjunappa
> <mallikarjunappa.sangannavar@intel.com>
> Subject: Re: [PATCH v5 1/2] dt-bindings: timer: Add bindings for Intel Keem
> Bay SoC Timer
>
> On Wed, Aug 4, 2021 at 8:35 AM Sanil, Shruthi <shruthi.sanil@intel.com>
> wrote:
> > > From: Rob Herring <robh@kernel.org>
> > > Sent: Tuesday, August 3, 2021 4:14 AM
>
> ...
>
> > > > +properties:
> > >
> > > You need a 'compatible' here. Otherwise, how does one know what 'reg'
> > > contains. Also, without it, this schema will never be applied.
> > >
> >
> > This is a parent block that has the common configuration register address
> defined which we would need during the initialization of the child nodes. This
> block in itself is not doing anything. We have this because, we have a
> common register that is required to be accessed during all the timers and
> counter initialization.
> > The child nodes have the compatible string, which is used in the driver. I
> have validated this on the Keem Bay HW and see that the timer probes are
> being called and the timers are functional as expected.
>
> I think I understand now. The problem is that the current state of affairs with
> this block is incorrect software representation. What you need is to create an
> MFD device driver (for which the compatible will exactly the one Rob is telling
> about) and from it you register the rest of your drivers. The existing drivers
> for this block should be converted to MFD schema.

Sure Andy, I shall check on this and get back.
Thank You!

>
> --
> With Best Regards,
> Andy Shevchenko
\
 
 \ /
  Last update: 2021-08-12 18:49    [W:0.091 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site