Messages in this thread | | | Date | Thu, 12 Aug 2021 18:43:18 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v2] crypto: sun8i-ce: fix multiple memory leaks in sun8i_ce_hash_run |
| |
On Thu, Aug 12, 2021 at 06:40:20PM +0800, Dongliang Mu wrote: > > I agree with you and would like to modify "return 0" to "return err" > in the next version. Even if the parent function does not care about > the return value, it is still necessary to keep the right return > value.
Well if the parent is ignoring the error then returning the error there obviously isn't going to help.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |