Messages in this thread | | | From | Andreas Färber <> | Subject | Re: [PATCH 1/8] dt-bindings: arm: fsl: add NXP S32G2 boards | Date | Thu, 12 Aug 2021 17:46:16 +0200 |
| |
Hello Rob and NXP,
On 05.08.21 08:54, Chester Lin wrote: > Add bindings for S32G2's evaluation board (S32G-VNP-EVB) and reference > design 2 board ( S32G-VNP-RDB2). > > Signed-off-by: Chester Lin <clin@suse.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index e2097011c4b0..3914aa09e503 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -983,6 +983,13 @@ properties: > - const: solidrun,lx2160a-cex7 > - const: fsl,lx2160a > > + - description: S32G2 based Boards > + items: > + - enum: > + - fsl,s32g274a-evb > + - fsl,s32g274a-rdb2
@Rob: Should for new boards the description: syntax be used also for enums? Or just at SoC level, and for board enums still traditional # comments?
> + - const: fsl,s32g2
@NXP: Is it sufficient here to have s32g2, or should we call this s32g274a and adjust the description above to S32G274A?
Related, is the trailing A for Arm, like for the Layerscape chips? I.e., not for Alpha or rev.A or something that will change for non-eval chips?
> + > - description: S32V234 based Boards > items: > - enum:
Otherwise,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks, Andreas
-- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)
| |