Messages in this thread Patch in this message | | | Date | Thu, 12 Aug 2021 15:12:59 -0000 | From | "irqchip-bot for Valentin Schneider" <> | Subject | [irqchip: irq/irqchip-next] irqchip/gic: Rely on MSI default .irq_eoi() |
| |
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 5a06c146b3af41e54add239cfda57e7d20f83026 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/5a06c146b3af41e54add239cfda57e7d20f83026 Author: Valentin Schneider <valentin.schneider@arm.com> AuthorDate: Tue, 29 Jun 2021 13:50:06 +01:00 Committer: Marc Zyngier <maz@kernel.org> CommitterDate: Thu, 12 Aug 2021 15:48:21 +01:00
irqchip/gic: Rely on MSI default .irq_eoi()
Previously, only platform-MSI irqchips would get a default .irq_eoi(). GIC-based platform-MSI irqchip's rely on this default callback, while PCI-MSI ones are initialized explicitly.
As all MSI domains now get a default .irq_eoi(), drop the explicit .irq_eoi() initialization for PCI-MSI chips.
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20210629125010.458872-10-valentin.schneider@arm.com --- drivers/irqchip/irq-gic-v2m.c | 1 - drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 1 - drivers/irqchip/irq-gic-v3-its-pci-msi.c | 1 - drivers/irqchip/irq-gic-v3-mbi.c | 1 - 4 files changed, 4 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c index be9ea6f..27a97c7 100644 --- a/drivers/irqchip/irq-gic-v2m.c +++ b/drivers/irqchip/irq-gic-v2m.c @@ -87,7 +87,6 @@ static struct irq_chip gicv2m_msi_irq_chip = { .name = "MSI", .irq_mask = gicv2m_mask_msi_irq, .irq_unmask = gicv2m_unmask_msi_irq, - .irq_eoi = irq_chip_eoi_parent, .irq_write_msi_msg = pci_msi_domain_write_msg, }; diff --git a/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c b/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c index 634263d..105ee64 100644 --- a/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c +++ b/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c @@ -21,7 +21,6 @@ static struct irq_chip its_msi_irq_chip = { .name = "ITS-fMSI", .irq_mask = irq_chip_mask_parent, .irq_unmask = irq_chip_unmask_parent, - .irq_eoi = irq_chip_eoi_parent, .irq_set_affinity = msi_domain_set_affinity }; diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c index ad2810c..14f6e63 100644 --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c @@ -27,7 +27,6 @@ static struct irq_chip its_msi_irq_chip = { .name = "ITS-MSI", .irq_unmask = its_unmask_msi_irq, .irq_mask = its_mask_msi_irq, - .irq_eoi = irq_chip_eoi_parent, .irq_write_msi_msg = pci_msi_domain_write_msg, }; diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c index e81e89a..a69ac29 100644 --- a/drivers/irqchip/irq-gic-v3-mbi.c +++ b/drivers/irqchip/irq-gic-v3-mbi.c @@ -169,7 +169,6 @@ static struct irq_chip mbi_msi_irq_chip = { .name = "MSI", .irq_mask = mbi_mask_msi_irq, .irq_unmask = mbi_unmask_msi_irq, - .irq_eoi = irq_chip_eoi_parent, .irq_compose_msi_msg = mbi_compose_msi_msg, .irq_write_msi_msg = pci_msi_domain_write_msg, };
| |