Messages in this thread | | | Date | Thu, 12 Aug 2021 18:04:37 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v2] crypto: sun8i-ce: fix multiple memory leaks in sun8i_ce_hash_run |
| |
On Tue, Aug 03, 2021 at 02:31:38PM +0800, Dongliang Mu wrote: > > -theend: > - kfree(buf); > +err_result: > kfree(result); > - crypto_finalize_hash_request(engine, breq, err); > +err_buf: > + kfree(buf); > +out: > + if (!err) > + crypto_finalize_hash_request(engine, breq, err); > return 0;
This does not look right. You're returning zero in case of an error
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |