Messages in this thread | | | Date | Tue, 10 Aug 2021 17:43:17 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH -next] staging: r8188eu: Use GFP_ATOMIC under spin lock |
| |
On Tue, Aug 10, 2021 at 08:53:14PM +0800, Yang Yingliang wrote: > A spin lock is taken in __nat25_db_network_insert() and > update_BCNTIM() is called under spin lock so we should > use GFP_ATOMIC in both place. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Good spot. This goes back to the original add a driver commit. It used to call rtw_malloc() but that was buggy.
Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |