Messages in this thread | | | Subject | Re: [PATCH] [PATCH v2] riscv: add as-options for modules with assembly compontents | From | Ben Dooks <> | Date | Tue, 10 Aug 2021 09:49:14 +0100 |
| |
On 20/07/2021 15:44, Ben Dooks wrote: > When trying to load modules built for RISC-V which include assembly files > the kernel loader errors with "unexpected relocation type 'R_RISCV_ALIGN'" > due to R_RISCV_ALIGN relocations being generated by the assembler. > > The R_RISCV_ALIGN relocations can be removed at the expense of code space > by adding -mno-relax to gcc and as. In commit 7a8e7da42250138 > ("RISC-V: Fixes to module loading") -mno-relax is added to the build > variable KBUILD_CFLAGS_MODULE. See [1] for more info. > > The issue is that when kbuild builds a .S file, it invokes gcc with > the -mno-relax flag, but this is not being passed through to the > assembler. Adding -Wa,-mno-relax to KBUILD_AFLAGS_MODULE ensures that > the assembler is invoked correctly. This may have now been fixed in > gcc[2] and this addition should not stop newer gcc and as from working. > > [1] https://github.com/riscv/riscv-elf-psabi-doc/issues/183 > [2] https://github.com/gcc-mirror/gcc/commit/3b0a7d624e64eeb81e4d5e8c62c46d86ef521857
Just wanted to check v2 is fine for merging, and if so when is that likely to be?
-- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
| |