Messages in this thread | | | Subject | Re: [PATCH 0/5] block: replace incorrect uses of GENHD_FL_UP | From | luomeng <> | Date | Wed, 11 Aug 2021 10:42:20 +0800 |
| |
Hi: When the fuzz test injected memory allocation failed, I had this BUG_ON: kernel BUG at fs/sysfs/group.c:116. The cause of the bug_ON is that the add_disk memory fails to be allocated but no error processing is performed. I find your patches add error processing. So what is your next step with these patches. Thanks.
Luo Meng
在 2021/7/21 2:20, Luis Chamberlain 写道: > I've bumped this from RFC to PATCH form as request by Christoph, > as it seems to line up with what he wants to do. As per Hannes > I also stuck to one form of naming, so went with blk_disk_added() > instead of blk_disk_registered() and used that instead of open > coding the flag check. > > This is rebased onto next-20210720 and I've made the patch series > independent of my *add_disk*() error handling series. This goes > compile and boot tested. > > Luis Chamberlain (5): > block: add flag for add_disk() completion notation > md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken() > mmc/core/block: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED > nvme: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED > fs/block_dev: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED > > block/genhd.c | 8 ++++++++ > drivers/md/md.h | 4 +--- > drivers/mmc/core/block.c | 2 +- > drivers/nvme/host/core.c | 4 ++-- > drivers/nvme/host/multipath.c | 2 +- > fs/block_dev.c | 5 +++-- > include/linux/genhd.h | 11 ++++++++++- > 7 files changed, 26 insertions(+), 10 deletions(-) >
| |