lkml.org 
[lkml]   [2021]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 144/175] md/raid10: properly indicate failure when ending a failed write request
    Date
    From: Wei Shuyu <wsy@dogben.com>

    commit 5ba03936c05584b6f6f79be5ebe7e5036c1dd252 upstream.

    Similar to [1], this patch fixes the same bug in raid10. Also cleanup the
    comments.

    [1] commit 2417b9869b81 ("md/raid1: properly indicate failure when ending
    a failed write request")
    Cc: stable@vger.kernel.org
    Fixes: 7cee6d4e6035 ("md/raid10: end bio when the device faulty")
    Signed-off-by: Wei Shuyu <wsy@dogben.com>
    Acked-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
    Signed-off-by: Song Liu <song@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/md/raid1.c | 2 --
    drivers/md/raid10.c | 4 ++--
    2 files changed, 2 insertions(+), 4 deletions(-)

    --- a/drivers/md/raid1.c
    +++ b/drivers/md/raid1.c
    @@ -472,8 +472,6 @@ static void raid1_end_write_request(stru
    /*
    * When the device is faulty, it is not necessary to
    * handle write error.
    - * For failfast, this is the only remaining device,
    - * We need to retry the write without FailFast.
    */
    if (!test_bit(Faulty, &rdev->flags))
    set_bit(R1BIO_WriteError, &r1_bio->state);
    --- a/drivers/md/raid10.c
    +++ b/drivers/md/raid10.c
    @@ -469,12 +469,12 @@ static void raid10_end_write_request(str
    /*
    * When the device is faulty, it is not necessary to
    * handle write error.
    - * For failfast, this is the only remaining device,
    - * We need to retry the write without FailFast.
    */
    if (!test_bit(Faulty, &rdev->flags))
    set_bit(R10BIO_WriteError, &r10_bio->state);
    else {
    + /* Fail the request */
    + set_bit(R10BIO_Degraded, &r10_bio->state);
    r10_bio->devs[slot].bio = NULL;
    to_put = bio;
    dec_rdev = 1;

    \
     
     \ /
      Last update: 2021-08-10 20:13    [W:5.850 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site