lkml.org 
[lkml]   [2021]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 44/85] usb: cdns3: Fixed incorrect gadget state
    Date
    From: Pawel Laszczak <pawell@cadence.com>

    commit aa35772f61752d4c636d46be51a4f7ca6c029ee6 upstream.

    For delayed status phase, the usb_gadget->state was set
    to USB_STATE_ADDRESS and it has never been updated to
    USB_STATE_CONFIGURED.
    Patch updates the gadget state to correct USB_STATE_CONFIGURED.
    As a result of this bug the controller was not able to enter to
    Test Mode while using MSC function.

    Cc: <stable@vger.kernel.org>
    Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
    Signed-off-by: Pawel Laszczak <pawell@cadence.com>
    Link: https://lore.kernel.org/r/20210623070247.46151-1-pawell@gli-login.cadence.com
    Signed-off-by: Peter Chen <peter.chen@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/cdns3/ep0.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/cdns3/ep0.c
    +++ b/drivers/usb/cdns3/ep0.c
    @@ -736,6 +736,7 @@ static int cdns3_gadget_ep0_queue(struct
    request->actual = 0;
    priv_dev->status_completion_no_call = true;
    priv_dev->pending_status_request = request;
    + usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED);
    spin_unlock_irqrestore(&priv_dev->lock, flags);

    /*

    \
     
     \ /
      Last update: 2021-08-10 19:38    [W:7.163 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site