lkml.org 
[lkml]   [2021]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 58/93] ASoC: soc-pcm: fix the return value in dpcm_apply_symmetry()
    Date
    From: Jaroslav Kysela <perex@perex.cz>

    [ Upstream commit 12ffd726824a2f52486f72338b6fd3244b512959 ]

    In case, where the loops are not executed for a reason, the uninitialized
    variable 'err' is returned to the caller. Make code fully predictible
    and assign zero in the declaration.

    Signed-off-by: Jaroslav Kysela <perex@perex.cz>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Link: https://lore.kernel.org/r/20210614071746.1787072-1-perex@perex.cz
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/soc-pcm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
    index 91bf33958159..8b8a9aca2912 100644
    --- a/sound/soc/soc-pcm.c
    +++ b/sound/soc/soc-pcm.c
    @@ -1738,7 +1738,7 @@ static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream,
    struct snd_soc_dpcm *dpcm;
    struct snd_soc_pcm_runtime *fe = asoc_substream_to_rtd(fe_substream);
    struct snd_soc_dai *fe_cpu_dai;
    - int err;
    + int err = 0;
    int i;

    /* apply symmetry for FE */
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-10 04:30    [W:4.046 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site