lkml.org 
[lkml]   [2021]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.13 067/114] ALSA: n64: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit be471fe332f7f14aa6828010b220d7e6902b91a0 ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Link: https://lore.kernel.org/r/20210610124958.116142-1-yangyingliang@huawei.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/mips/snd-n64.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/sound/mips/snd-n64.c b/sound/mips/snd-n64.c
    index e35e93157755..463a6fe589eb 100644
    --- a/sound/mips/snd-n64.c
    +++ b/sound/mips/snd-n64.c
    @@ -338,6 +338,10 @@ static int __init n64audio_probe(struct platform_device *pdev)
    strcpy(card->longname, "N64 Audio");

    res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
    + if (!res) {
    + err = -EINVAL;
    + goto fail_dma_alloc;
    + }
    if (devm_request_irq(&pdev->dev, res->start, n64audio_isr,
    IRQF_SHARED, "N64 Audio", priv)) {
    err = -EBUSY;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-10 04:20    [W:4.203 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site