Messages in this thread | | | From | Nava kishore Manne <> | Subject | RE: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API support | Date | Fri, 9 Jul 2021 08:41:35 +0000 |
| |
Hi Greg,
Thanks for providing the review comments. Please find my response inline.
> -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Wednesday, June 9, 2021 3:25 PM > To: Nava kishore Manne <navam@xilinx.com> > Cc: robh+dt@kernel.org; Michal Simek <michals@xilinx.com>; > mdf@kernel.org; trix@redhat.com; arnd@arndb.de; Rajan Vaja > <RAJANV@xilinx.com>; Amit Sunil Dhamne <amitsuni@xlnx.xilinx.com>; > Tejas Patel <tejasp@xlnx.xilinx.com>; zou_wei@huawei.com; Sai Krishna > Potthuri <lakshmis@xilinx.com>; Ravi Patel <RAVIPATE@xilinx.com>; > iwamatsu@nigauri.org; Jiaying Liang <jliang@xilinx.com>; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-fpga@vger.kernel.org; git <git@xilinx.com>; > chinnikishore369@gmail.com > Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API > support > > On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote: > > This patch adds user encrypted key load API to support User key > > encrypted images loading use cases from Linux. > > What is "user key encrypted images"? Do we need more documentation > here for what this is and how to use it? >
Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode. User can supply a 128-bit Initial Vector and 256-bit key(user key). For more info please refer here: https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf
> And why is "User" capitalized? >
Will fix.
Regards, Navakishore.
| |