lkml.org 
[lkml]   [2021]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 13/33] scsi: qedi: Fix null ref during abort handling
    Date
    From: Mike Christie <michael.christie@oracle.com>

    [ Upstream commit 5777b7f0f03ce49372203b6521631f62f2810c8f ]

    If qedi_process_cmd_cleanup_resp finds the cmd it frees the work and sets
    list_tmf_work to NULL, so qedi_tmf_work should check if list_tmf_work is
    non-NULL when it wants to force cleanup.

    Link: https://lore.kernel.org/r/20210525181821.7617-20-michael.christie@oracle.com
    Reviewed-by: Manish Rangankar <mrangankar@marvell.com>
    Signed-off-by: Mike Christie <michael.christie@oracle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qedi/qedi_fw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
    index e8f2c662471e..662444bb67f6 100644
    --- a/drivers/scsi/qedi/qedi_fw.c
    +++ b/drivers/scsi/qedi/qedi_fw.c
    @@ -1474,7 +1474,7 @@ static void qedi_tmf_work(struct work_struct *work)

    ldel_exit:
    spin_lock_bh(&qedi_conn->tmf_work_lock);
    - if (!qedi_cmd->list_tmf_work) {
    + if (qedi_cmd->list_tmf_work) {
    list_del_init(&list_work->list);
    qedi_cmd->list_tmf_work = NULL;
    kfree(list_work);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-10 04:40    [W:4.058 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site