lkml.org 
[lkml]   [2021]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 29/63] ASoC: img: Fix PM reference leak in img_i2s_in_probe()
    Date
    From: Yufen Yu <yuyufen@huawei.com>

    [ Upstream commit 81aad47278539f02de808bcc8251fed0ad3d6f55 ]

    pm_runtime_get_sync will increment pm usage counter even it failed.
    Forgetting to putting operation will result in reference leak here.
    Fix it by replacing it with pm_runtime_resume_and_get to keep usage
    counter balanced.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yufen Yu <yuyufen@huawei.com>
    Link: https://lore.kernel.org/r/20210524093521.612176-1-yuyufen@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/img/img-i2s-in.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
    index bb668551dd4b..243f916355ee 100644
    --- a/sound/soc/img/img-i2s-in.c
    +++ b/sound/soc/img/img-i2s-in.c
    @@ -464,7 +464,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
    if (ret)
    goto err_pm_disable;
    }
    - ret = pm_runtime_get_sync(&pdev->dev);
    + ret = pm_runtime_resume_and_get(&pdev->dev);
    if (ret < 0)
    goto err_suspend;

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-10 04:39    [W:5.598 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site