Messages in this thread Patch in this message | | | From | Fabio Estevam <> | Date | Fri, 9 Jul 2021 00:36:25 -0300 | Subject | Re: [PATCH] iio: accel: fxls8962af: Initialize return value |
| |
Hi Souptick,
On Fri, Jul 9, 2021 at 12:17 AM Souptick Joarder <jrdr.linux@gmail.com> wrote: > > kernel test robot throws below warning -> > > smatch warnings: > drivers/iio/accel/fxls8962af-core.c:640 > fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'. > > Initialize it. > > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > drivers/iio/accel/fxls8962af-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c > index 078d87865fde..8af1c8f58e83 100644 > --- a/drivers/iio/accel/fxls8962af-core.c > +++ b/drivers/iio/accel/fxls8962af-core.c > @@ -628,7 +628,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data, > u16 *buffer, int samples, > int sample_length) > { > - int i, ret; > + int i, ret = -EINVAL; > > for (i = 0; i < samples; i++) { > ret = regmap_raw_read(data->regmap, FXLS8962AF_BUF_X_LSB,
Would the change below work?
--- a/drivers/iio/accel/fxls8962af-core.c +++ b/drivers/iio/accel/fxls8962af-core.c @@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data, return ret; }
- return ret; + return 0; }
| |