Messages in this thread | | | Date | Thu, 8 Jul 2021 14:33:44 -0700 | From | "Raj, Ashok" <> | Subject | Re: Programming PASID in IMS entries |
| |
Hi Thomas,
On Thu, Jul 08, 2021 at 08:45:48PM +0200, Thomas Gleixner wrote: > Ashok, > > >> > IMS core owns the format of the entries right now vs device specific driver. > >> > I suppose your use case requiring a vm_id might have a different format. > >> > So this is yet another one the core needs to learn and adapt? > >> > >> All entry format stuff is device specific, it shouldn't be in "core" > >> code. > > > > Well, this is how it started way back last year. > > > > https://lore.kernel.org/lkml/158751209583.36773.15917761221672315662.stgit@djiang5-desk3.ch.intel.com/ > > Which is wrong on so many levels as we all know.
Sorry, I was just trying to point to Jason, that its how things started. Since he was suggesting to have them as device specific.
> > > Where the driver functions for mask/unmask/write_msg etc. So the core > > needs > > Needs what?
Fat fingered that reply.. I completed it partially but moved to a different sentence formation :-( > > > So the format or layout is device specific, but core can dictate the exact > > message that needs to be written. > > Sorry, I don't grok what you want to say here.
Sorry it was unclear.. I meant things like compose_msg()
Cheers, Ashok
| |