Messages in this thread | | | Date | Thu, 8 Jul 2021 16:11:58 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/2 v3] tracing/histogram: Update the documentation for the buckets modifier |
| |
On Thu, 08 Jul 2021 15:05:16 -0500 Tom Zanussi <zanussi@kernel.org> wrote:
> > - # echo 'hist:key=call_site:val=bytes_req' > \ > > + # echo 'hist:key=call_site:val=bytes_req.buckets=32' > \ > > /sys/kernel/debug/tracing/events/kmem/kmalloc/trigger > > This just seems random, not sure why you changed it, and it doesn't > make sense on a val anyway..
Good catch! I originally wrote this to explain the buckets in this location, and then realized it did not match the flow, and moved my text down. It appears that I missed putting back the original trigger. Will fix and send a v4.
> > The rest looks good, though, thanks for doing this! > > Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Thanks!
-- Steve
| |