lkml.org 
[lkml]   [2021]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/13] mailbox: pcc: Rename doorbell ack to platform interrupt ack register
    Date
    The specification refers this register and associated bitmask as platform
    interrupt acknowledge register. Let us rename it so that it is easier to
    map and understand.

    Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
    ---
    drivers/mailbox/pcc.c | 13 +++++++------
    1 file changed, 7 insertions(+), 6 deletions(-)

    diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
    index 49971e007e40..c4eecccac4b8 100644
    --- a/drivers/mailbox/pcc.c
    +++ b/drivers/mailbox/pcc.c
    @@ -69,13 +69,14 @@ static struct mbox_chan *pcc_mbox_channels;
    *
    * @chan: PCC channel information with Shared Memory Region info
    * @db_vaddr: cached virtual address for doorbell register
    - * @db_ack_vaddr: cached virtual address for doorbell ack register
    + * @plat_irq_ack_vaddr: cached virtual address for platform interrupt
    + * acknowledge register
    * @db_irq: doorbell interrupt
    */
    struct pcc_chan_info {
    struct pcc_mbox_chan chan;
    void __iomem *db_vaddr;
    - void __iomem *db_ack_vaddr;
    + void __iomem *plat_irq_ack_vaddr;
    int db_irq;
    };

    @@ -198,12 +199,12 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
    doorbell_ack_preserve = pcct2_ss->ack_preserve_mask;
    doorbell_ack_write = pcct2_ss->ack_write_mask;

    - ret = read_register(pchan->db_ack_vaddr,
    + ret = read_register(pchan->plat_irq_ack_vaddr,
    &doorbell_ack_val, doorbell_ack->bit_width);
    if (ret)
    return IRQ_NONE;

    - ret = write_register(pchan->db_ack_vaddr,
    + ret = write_register(pchan->plat_irq_ack_vaddr,
    (doorbell_ack_val & doorbell_ack_preserve)
    | doorbell_ack_write,
    doorbell_ack->bit_width);
    @@ -406,10 +407,10 @@ static int pcc_parse_subspace_irq(struct pcc_chan_info *pchan,
    if (pcct_ss->header.type == ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE_TYPE2) {
    struct acpi_pcct_hw_reduced_type2 *pcct2_ss = (void *)pcct_ss;

    - pchan->db_ack_vaddr =
    + pchan->plat_irq_ack_vaddr =
    acpi_os_ioremap(pcct2_ss->platform_ack_register.address,
    pcct2_ss->platform_ack_register.bit_width / 8);
    - if (!pchan->db_ack_vaddr) {
    + if (!pchan->plat_irq_ack_vaddr) {
    pr_err("Failed to ioremap PCC ACK register\n");
    return -ENOMEM;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-07-08 20:09    [W:4.438 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site