lkml.org 
[lkml]   [2021]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: net: Follow the indentation coding standard on printks
From
Date
On Thu, 2021-07-08 at 11:23 -0400, Carlos Bilbao wrote:
> Fix indentation of printks that start at the beginning of the line. Change this
> for the right number of space characters, or tabs if the file uses them.

The tulip and sb1000 code are from the 1990's.
Likely this doesn't need touching, but if you really want to:

> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c
[]
> @@ -3169,7 +3169,7 @@ dc2114x_autoconf(struct net_device *dev)
>  
>
>      default:
>   lp->tcount++;
> -printk("Huh?: media:%02x\n", lp->media);
> + printk("Huh?: media:%02x\n", lp->media);

There should be a KERN_<LEVEL> here like KERN_WARNING/KERN_NOTICE

> diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
[]
> @@ -760,7 +760,7 @@ sb1000_rx(struct net_device *dev)
>  
>
>   insw(ioaddr, (unsigned short*) st, 1);
>  #ifdef XXXDEBUG
> -printk("cm0: received: %02x %02x\n", st[0], st[1]);
> + printk("cm0: received: %02x %02x\n", st[0], st[1]);
>  #endif /* XXXDEBUG */

XXXDEBUG isn't defined anywhere so these could just be deleted.

> @@ -805,7 +805,7 @@ printk("cm0: received: %02x %02x\n", st[0], st[1]);
>   /* get data length */
>   insw(ioaddr, buffer, NewDatagramHeaderSize / 2);
>  #ifdef XXXDEBUG
> -printk("cm0: IP identification: %02x%02x fragment offset: %02x%02x\n", buffer[30], buffer[31], buffer[32], buffer[33]);
> + printk("cm0: IP identification: %02x%02x fragment offset: %02x%02x\n", buffer[30], buffer[31], buffer[32], buffer[33]);
>  #endif /* XXXDEBUG */
>   if (buffer[0] != NewDatagramHeaderSkip) {
>   if (sb1000_debug > 1)


\
 
 \ /
  Last update: 2021-07-08 18:41    [W:0.099 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site