lkml.org 
[lkml]   [2021]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/6] x86/tdx: Add TDREPORT TDX Module call support
From
Date


On 7/8/21 1:16 AM, Xiaoyao Li wrote:
>
> Sorry I guess I didn't state it clearly during internal review.
>
> I suggest something like this
>
> if (ret != TDCALL_SUCCESS) {
>     if (TDCALL_RETURN_CODE(ret) == TDCALL_INVALID_OPERAND)
>         return -EINVAL;
>     else if (TDCALL_RETURN_CODE(ret) == TDCALL_OPERAND_BUSY)
>         return -EBUSY;
>     else
>         return -EFAULT; //I'm not sure if -EFAULT is proper.
> }

As per current spec, TDCALL_INVALID_OPERAND, TDCALL_OPERAND_BUSY and
0 are the only possible return values. So I have checked for failure case
in if condition and returned success by default. Any reason for specifically
checking for success code ?

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer

\
 
 \ /
  Last update: 2021-07-08 16:08    [W:0.719 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site